Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-v1.3.2 AccountAgeWitnessServiceTest > testArbitratorSignWitness FAILED #4158

Closed
ghubstan opened this issue Apr 10, 2020 · 0 comments · Fixed by #4161
Closed

release-v1.3.2 AccountAgeWitnessServiceTest > testArbitratorSignWitness FAILED #4158

ghubstan opened this issue Apr 10, 2020 · 0 comments · Fixed by #4161

Comments

@ghubstan
Copy link
Contributor

ghubstan commented Apr 10, 2020 •
edited
Loading

Description

Core's testArbitratorSignWitness fails during cmd line build, therefore jars, start scripts and packages cannot be built (unless tests are not run).

Version

Release branch release/v1.3.2

Steps to reproduce

Linux: ./gradlew clean build

Expected behaviour

All tests should pass

Actual behaviour

Build fails:

bisq.core.account.witness.AccountAgeWitnessServiceTest > testArbitratorSignWitness FAILED
    java.lang.AssertionError at AccountAgeWitnessServiceTest.java:220
        AssertionError: expected:<0> but was:<2>

The assertion error's wording is a bit misleading. It should say expected:<2> but was:<0>
after the assert arguments are corrected: assertEquals(items.size(), 2);
is changed to assertEquals(2, items.size());

Device or machine

Linux / Ubuntu 18 / OpenJDK 11

Additional info

This tests PASSES when run in Intellij.

I have run the cmd line build (w/ tests), and run AccountAgeWitnessServiceTest in IDE several times to make sure this is the case: fails on cmd line, passes in IDE.

Note that this failing test is the only one of three test cases in AccountAgeWitnessServiceTest that is not ignored.
ghubstan added a commit to ghubstan/bisq that referenced this issue Apr 11, 2020
@ghubstan
Replace mock arg with SEPA PaymentMethod instance
fc458e7 
Test AccountAgeWitnessServiceTest > testArbitratorSignWitness failed
in full gradle build, but passed when run as a single test:

	./gradlew :core:cleanTest :core:test \
		--tests "bisq.core.account.witness.AccountAgeWitnessServiceTest"

This test also passed when run in the IDE.

Solved by not passing a mocked PaymentMethod.SEPA argument into the
test's service.getTraderPaymentAccounts() method, where mock paymentId
field was null when running full build's test suites.

Fix for bisq-network#4158
@ghubstan ghubstan mentioned this issue Apr 11, 2020
Merged
ripcurlx pushed a commit that referenced this issue Apr 13, 2020
@ghubstan @ripcurlx
Replace mock arg with SEPA PaymentMethod instance
be09682 
Test AccountAgeWitnessServiceTest > testArbitratorSignWitness failed
in full gradle build, but passed when run as a single test:

	./gradlew :core:cleanTest :core:test \
		--tests "bisq.core.account.witness.AccountAgeWitnessServiceTest"

This test also passed when run in the IDE.

Solved by not passing a mocked PaymentMethod.SEPA argument into the
test's service.getTraderPaymentAccounts() method, where mock paymentId
field was null when running full build's test suites.

Fix for #4158
@ghubstan ghubstan mentioned this issue Apr 13, 2020
Closed
@ghubstan ghubstan mentioned this issue Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace mock arg with SEPA PaymentMethod instance ghubstan/bisq
1 participant
@ghubstan