Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve grpc-auth and gson dependency conflicts #4108

Merged

Conversation

ghubstan
Copy link
Member

@ghubstan ghubstan commented Apr 1, 2020

This change forces :relay's grpc-auth version to match the
version of all other io.grpc-* dependencies, and gets rid of
the duplcate gson dependency v2.8.2

Partial fix for #4086

This change forces :relay's grpc-auth version to match the
version of all other io.grpc-* dependencies, and gets rid of
the duplcate gson dependency v2.8.2
@ghubstan ghubstan requested a review from cbeams as a code owner April 1, 2020 14:02
@ghubstan
Copy link
Member Author

ghubstan commented Apr 1, 2020

close/open to trigger new travis build

@ghubstan ghubstan closed this Apr 1, 2020
@ghubstan ghubstan reopened this Apr 1, 2020
@ghubstan
Copy link
Member Author

ghubstan commented Apr 2, 2020

close/open again, to trigger new travis build

@ghubstan ghubstan closed this Apr 2, 2020
@ghubstan ghubstan reopened this Apr 2, 2020
Copy link
Member

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #4108 (review)

@ripcurlx ripcurlx merged commit fbfe8dc into bisq-network:master Apr 6, 2020
@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Apr 6, 2020
@ghubstan ghubstan deleted the rslv-grpcauth-gson-dep-conflicts branch April 6, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants