For Cycle 66

[alvasw]

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

• BSQ requested: 6048.39
• USD requested: 15000
• BSQ rate: 2.48 USD per BSQ
• Previous compensation request (if applicable): For Cycle 65 #1685

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title	Team	USD	Link	Notes
bisq: PR Review bisq-network/bisq#7325	dev		bisq-network/bisq#7325	utACK
bisq: PR Review bisq-network/bisq#7326	dev		bisq-network/bisq#7326	utACK
bisq: PR Review bisq-network/bisq#7327	dev		bisq-network/bisq#7327	utACK
bisq: getoffers (api): Return all offers by default	dev		bisq-network/bisq#7329	The getoffers api doesn't return any offers until the user has created his payment accounts. Afterward the api will only return offers that the user can take. This behavior is confusing and frustrating for new developers. The new behavior is to show all offers for a given market (direction, currency) by default. Changes: api: Remove getoffers' --all option getoffers: Include offers that can't be taken api: Include my offers in getoffers
bisq: Write tests for HistoricalDataStoreService.getMapSinceVersion(...)	dev		bisq-network/bisq#7330
bisq: Fix getdata response for preleases	dev		bisq-network/bisq#7331	Send back seednode version in get data response back to client Filter for known items in HistoricalDataStoreService.getMapSinceVersion(...) Remove redundant Map creation in HistoricalDataStoreService.getMapSinceVersion(...) Cap items if requesterVersion is null in HistoricalDataStoreService.getMapSinceVersion(...) Cap items if requesterVersion is newer in HistoricalDataStoreService.getMapSinceVersion(...) Set wasPersistableNetworkPayloadsTruncated if requester Version newer and capped Cap items if requesterVersion is newer in HistoricalDataStoreService.getMapSinceVersion(...) Include responders missing hashes from our historical data store
bisq: Show ARS Blue Rate popup during payment account creation	dev		bisq-network/bisq#7338	At the moment, we show the ARS Blue Rate popup when the user saves a single currency payment account (PR #7122). This misses many payment accounts that support ARS. The new behaviour is to show the ARS Blue Rate popup when ARS is selected during account generation (either pre-selected or later selected by the user). Payment accounts supporting ARS: CashByMail CashDeposit F2F MoneyGram National bank OKPayAccount (deprecated) Same bank Specific bank Transferwise Uphold Western Union
bisq: Always show ARS blue rate popup (account creation)	dev		bisq-network/bisq#7340	We show the ARS blue rate popup whenever the user creates a payment method and ARS is selected. Therefore, it makes sense to always show the ARS blue rate popup. Changes: Move ARS blue rate popup code to new class Always show ARS blue rate popup
bisq: Show ARS blue rate popup when selecting currency in app	dev		bisq-network/bisq#7341	OfferBookChartView: Show ARS blue rate popup if selected TradesChartsView: Show ARS blue rate popup if selected OfferBookView: Show ARS blue rate popup if selected PreferencesView: Show ARS blue rate popup if selected
bisq: Updater: Remove JAR_HASH download	dev		bisq-network/bisq#7342	Recent changes broke reproducibility and the last release's JAR_HASH file contains "Dummy file (needed for updater)". We need to keep creating a dummy file because the updater fails without a dummy file. This change fixes the bug.
bisq: Fix crash due to broken filter provided nodes merge	dev		bisq-network/bisq#7343	The filter provided nodes were added to a read-only List and this lead to crashes at start-up. We didn't catch the bug before because the lists in the tests are mutable. Now the FederatedBtcNodeProvider.getNodes method operates on Streams.
bisq: Refactor baseCurrencyNetwork field to getter access	dev		bisq-network/bisq#7353
bisq: Fix DaoSnapshotService threading issues	dev		bisq-network/bisq#7354	DaoSnapshot: Fix persistingBlockInProgress data race The persistingBlockInProgress field is read by the block parsing thread. However, the block parsing thread and user thread write to the persistingBlockInProgress field. The block parsing thread might see the update too late and trigger another snapshot before the previous was done. DaoSnapshot: Skip snapshot creation early if another in progress Check if another snapshot creation is in progress before doing any computation. DaoSnapshot: Fix isParseBlockChainComplete field data race DaoSnapshot: Fix race condition in applySnapshot DaoSnapshot: Fix resyncDaoStateFromResources race condition
bisq: RestApi: Fix parseBlockCompleteAfterBatchProcessing data race	dev		bisq-network/bisq#7355	The parseBlockCompleteAfterBatchProcessing field is set on the block parsing thread and read by Jersey's HTTP threads. By default, Jersey handles requests synchronous on multiple threads.
PR Review (for v1.9.19): Do not navigate to open offers after user has clicked dont show again	dev		bisq-network/bisq#7115	I reviewed all PR since the last release to catch potential issues before they arise.
PR Review (for v1.9.19): Remove survey link and related text at trade complete feedback	dev		bisq-network/bisq#7120	I found mistake in the updated text.
PR Review (for v1.9.19): Don't show ARS blue market price warning at startup	dev		bisq-network/bisq#7122	This PR is incomplete and handles only single currency payment accounts. Therefore, the popup won't show when ARS is selected in multi-currency payment accounts. Apart from that, the ARS popup is shown after the user created his payment accounts. I opened several PRs to improve usability. The new behavior is to show the ARS popup when the user selects ARS or it gets auto-selected during payment account creation. Additionally, we show the ARS popup when the user selects it as a currency in Bisq (offerbook, trade charts, trade statistics, and preferences). All popups except the ones during payment account creation have a "Don't show again" checkbox.
PR Review (for v1.9.19): Only show XMR subaddress recommendation if the user has a XMR account setup	dev		bisq-network/bisq#7123	I fixed a NullPointerException, broken URLs, and improved the behaviour in follow up PRs. Now we show the XMR subaddress if the user has a non-subaddress XMR account and when the user creates a new XMR account.
PR Review (for v1.9.19): Deactivate QrCodeProcessorTest [1]	dev		bisq-network/bisq#7177	utACK
PR Review (for v1.9.19): Improve logs [2]	dev		bisq-network/bisq#7175	utACK
PR Review (for v1.9.19): Update btc nodes [3]	dev		bisq-network/bisq#7176	utACK
PR Review (for v1.9.19): Remove unused test resources	dev		bisq-network/bisq#7178	ACK
PR Review (for v1.9.19): Various refactoring (renameing) and cleanups [A]	dev		bisq-network/bisq#7179	utACK
PR Review (for v1.9.19): Further refactorings and improvements [B]	dev		bisq-network/bisq#7180	utACK
PR Review (for v1.9.19): Improve resync handling [C]	dev		bisq-network/bisq#7181	utACK - I found and fixed threading issues unrelated to this PR while reviewing this PR.
PR Review (for v1.9.19): Improve seednode [D]	dev		bisq-network/bisq#7182	utACK
PR Review (for v1.9.19): Refactor ExecutableForAppWithP2p [E]	dev		bisq-network/bisq#7183	utACK
PR Review (for v1.9.19): Do not clear tor files at update to new version	dev		bisq-network/bisq#7184	utACK
PR Review (for v1.9.19): Resolve issues with javacv	dev		bisq-network/bisq#7171	utACK
PR Review (for v1.9.19): Update seednode files	dev		bisq-network/bisq#7102	utACK
PR Review (for v1.9.19): Add missing snapshot creation in full DAO mode	dev		bisq-network/bisq#7185	utACK
PR Review (for v1.9.19): Fix bug with using wrong collection which held only one bond per hash [1]	dev		bisq-network/bisq#7186	utACK
PR Review (for v1.9.19): Add tx id to proof of burn and bond dtos [2]	dev		bisq-network/bisq#7187	utACK
PR Review (for v1.9.19): Remove emzy seednodes from inventory monitor	dev		bisq-network/bisq#7188	utACK
PR Review (for v1.9.19): Set useFullModeDaoMonitor to true in all headless apps	dev		bisq-network/bisq#7189	utACK
PR Review (for v1.9.19): Remove mrosseel btc node	dev		bisq-network/bisq#7193	utACK
PR Review (for v1.9.19): Improve btc monitor	dev		bisq-network/bisq#7194	utACK
PR Review (for v1.9.19): Set -fx-font-smoothing-type to grey.	dev		bisq-network/bisq#7196	utACK
PR Review (for v1.9.19): Check burning man receiver address validity	dev		bisq-network/bisq#7203	utACK
PR Review (for v1.9.19): Remove nodes	dev		bisq-network/bisq#7137	utACK
PR Review (for v1.9.19): Reset AutoConfirmSettings if it contains a retired address	dev		bisq-network/bisq#7137	utACK
PR Review (for v1.9.19): Add rest api endpoints for bsq explorer	dev		bisq-network/bisq#7207	utACK - I found a threading issue.
	dev	15000		Total for items above.

[alvasw]

d7a3e54a287316932d18dd2e9b3d5e070be259c76c31b4e632abb6b0a18f92d2