Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nodes #7137

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

devinbileck
Copy link
Member

No need to merge this right away as I will keep them running for a while longer.

Copy link

github-actions bot commented Jul 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@devinbileck
Copy link
Member Author

Not stale

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.18 milestone Jul 19, 2024
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83
Copy link
Contributor

Hi @devinbileck!
I'm sorry for the delay. Could you please rebase this PR against master again? I tried to do it myself but it breaks the GPG signature. Thank you!

@HenrikJannsen
Copy link
Collaborator

We should also remove persisted entries like done in BisqSetup.maybeUpgradeBsqExplorerUrl with other retired nodes.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants