Add missing snapshot creation in full DAO mode #7185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sHeightAtLeastGenesisHeight Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…y. Inline statement Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
force-pushed
the
fix-missing-snapshot-creation
branch
from
779ffc5 to
262840b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running a full DAO node but not having Full mode for DAO Monitor activated we did not create snapshots while parsing blocks.
This was bad when doing a resync as only after parsing complete which can take very long in case of a resync from genesis there have been no blocks and state persisted. Activating Full mode for DAO Monitor would slow down parsing as at each block the dao state hash would get created.
With this PR we create snapshots if full DAO mode is activated.
However when running a full DAO node it is recommended to set
--useFullModeDaoMonitorto true to ensure the linked list of dao state hashes is correct and we do not depend on data provided by seed nodes.