Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 42 #1198

Closed
alvasw opened this issue Dec 5, 2022 · 5 comments
Closed

For Cycle 42 #1198

alvasw opened this issue Dec 5, 2022 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Dec 5, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 10000
  • USD requested: 7500
  • BSQ rate: 0.75 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 41 #1179

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
BitcoindRegtest: Mine initial regtest block on startup dev bisq-network/bisq2#534
Gradle: Disable Bisq 2 Bitcoin Wallet Regtest Task dev bisq-network/bisq2#535
UI: Remove Bitcoin Core Wallet Support dev bisq-network/bisq2#536
Disable BitcoinWalletService initialization dev bisq-network/bisq2#537
JsonRpcClient: Pretty log full request and response dev bisq-network/bisq2#538
Gradle: Disable Bisq 2 Elements Wallet Regtest Task dev bisq-network/bisq2#539
UI: Remove Elements Core Wallet Support dev bisq-network/bisq2#540
UI: Remove Wallet Config Popup dev bisq-network/bisq2#541
ApplicationService.Config: Remove Bitcoin Core and Elements Core Regtest configs dev bisq-network/bisq2#543
Implement ElectrumWalletService dev bisq-network/bisq2#544
UI: Support Electrum Wallet dev bisq-network/bisq2#545
BisqElectrumPlugin: Create directory constants dev bisq-network/bisq2#546
Electrum: Don't package DMG image dev bisq-network/bisq2#547
Fix: Electrum Windows Executable Hash dev bisq-network/bisq2#548
macOS: Unpack Electrum.app at build time dev bisq-network/bisq2#549
Fix Typesafe Merge Error caused by wallet.enabled setting dev bisq-network/bisq2#550
Fix: macOS App file permission loss bug dev bisq-network/bisq2#551
ElectrumWalletService: Expose balance as observable coin dev bisq-network/bisq2#552
Implement new simplified wallet UI dev bisq-network/bisq2#553 The previous wallet UI was an early prototype to test the wallet functionalities. It was not user-friendly. The new wallet UI exposes only the basic functionalities to the user.
Fix sending stop signal twice to Electrum daemon dev bisq-network/bisq2#554 The ElectrumProcess and ElectrumWallet both called the stop RPC call in their shutdown methods. The ElectrumProcess should be the one who is responsible for shutting down the daemon. Sadly, Electrum does not provide a unload wallet RPC method.
Switch from AES-CBC to AES-GCM dev bisq-network/bisq2#555 AES in Galois/Counter Mode (GCM) provides authenticity and confidentiality (AEDEAD). We have to ensure that we use unique IVs. This means we no longer need to handle authentication manually. GCM can ran fully parallelized compared to CBC.
Generalize binary downloader/verifier dev bisq-network/bisq2#571 The new generic download task can download any file and can check its SHA-256 checksum (optional). The signature verifier can be used for any file now. This allows us to reuse the tasks to download the Tor binaries later.
Other changes:
Currently, all Electrum binaries get zipped and moved to the app resources. This okay until we decided to unpack the Electum.app file at build time. To build the macOS version we require macOS as the host operating system now.
Fixes #561
i18n: Remove old/unused string from wallet ui dev bisq-network/bisq2#572
Security: Rename cyphertext to ciphertext dev bisq-network/bisq2#573
HybridEncryption: Remove BouncyCastle Provider loading dev bisq-network/bisq2#574
build-logic: Make sha256 hash optional in DownloadTask dev bisq-network/bisq2#575
build-logic: Make FileVerificationTask cachable dev bisq-network/bisq2#576
ElementsDaemon: Create/Use legacy wallet dev bisq-network/bisq2#577
dev 7500 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Dec 5, 2022
@MwithM MwithM added this to the Cycle 42 milestone Dec 5, 2022
@alvasw
Copy link
Author

alvasw commented Dec 7, 2022

I already submitted my proposal because I need to do a SPV resync.

@alvasw
Copy link
Author

alvasw commented Dec 7, 2022

d267091f36ef5a9c46ec5b80fe0d82307abf6fd00d8f65e2f554396ba8bf2ef6

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 9, 2022

As dev team lead I approve this compensation request for dev.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 22, 2022
@ghost
Copy link

ghost commented Dec 22, 2022

Issuance by Team:

team amount BSQ amount USD
dev 10000.00 7500.00

Total Issuance: 10000.00 BSQ (equivalent to: 7500.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 22, 2022

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants