Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 41 #1179

Closed
alvasw opened this issue Nov 2, 2022 · 5 comments
Closed

For Cycle 41 #1179

alvasw opened this issue Nov 2, 2022 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Nov 2, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8000
  • USD requested: 6000
  • BSQ rate: 0.75 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 40 #1159

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
BitcoindMineInitialRegtestBlocks: Increase timeout to 1 minute dev bisq-network/bisq2#511
Let Bitcoin Core manage its wallet files dev bisq-network/bisq2#512 Currently, we store the Bitcoin Core wallet files in Bisq's data directory. The disadvantage of this approach is that we cannot run Bitcoin Core on another machine. This change lets Bitcoin Core fully manage all its wallet files.
Use one global bitcoind instance for all integration tests dev bisq-network/bisq2#513 At the moment, each test class starts its own Bitcoin Core instance. This causes slow CI tests and high resource usage.
Electrum: Enable Windows Support dev bisq-network/bisq2#514
Windows: Switch to regular Electrum executable dev bisq-network/bisq2#515 Switch from portable Windows executable to regular executable.
Electrum: Fix ElectrumX (server) hostname dev bisq-network/bisq2#516 Electrum assumed that ElectrumX (server) is running on the same host. This assumption is not true on Windows because ElectrumX is not officially supported on Windows. Most devs run the ElectrumX server in a Linux container or VM and connect to it from Windows.
GitHub Actions: Use absolute bin path (ElectrumX) dev bisq-network/bisq2#519
Create json-rpc library dev bisq-network/bisq2#520 The json-rpc library that we are currently using doesn't properly clean up all resources. On Windows it blocks the Electrum Daemon. It's better to create a new simple json-rpc client that supports batching and asynchronous calls.
Electrum: Migrate from CLI to JSON-RPC dev bisq-network/bisq2#521 We generated the config file using the electrum binary in the past which lead to several issues. Now, we manually generate the config file and no longer need to rely on the CLI.
Electrum: Switch to new JSON-RPC library dev bisq-network/bisq2#522 The old JSON-RPC library blocks Electrum on Windows after a few RPC calls. Adapting the old JSON-RPC library turned out to be harder than switching to a modern approach (supporting asynchronous calls, ...). Then new library is more flexible and performant.
Electrum: Remove Jackson Databind dependency dev bisq-network/bisq2#523 This dependecy was needed for the old JSON-RPC library.
BitcoindGetAddressInfoResponse: Follow field naming convention dev bisq-network/bisq2#524
Move AssertJ testing library to 'java-conventions' project type dev bisq-network/bisq2#525
JSON-RPC: Specify OkHttp lib version using BOM dev bisq-network/bisq2#526
Add HttpLoggingInterceptor to JsonRpcClient dev bisq-network/bisq2#527
JSON-RPC: Specify OkHttp BOM and Moshi in version catalog dev bisq-network/bisq2#528
Electrum: Remove setters in RPC response classes dev bisq-network/bisq2#529
GitHub Actions: Remove unused ids from build.yml dev bisq-network/bisq2#530
GitHub Actions: Rename 'setup-bitcoin-core' action to 'install-wallets' dev bisq-network/bisq2#531
Use single ElectrumXServer instance for all integration tests dev bisq-network/bisq2#532
Use single Electrum instance for all integration tests dev bisq-network/bisq2#533
dev 6000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 2, 2022
@MwithM MwithM added this to the Cycle 41 milestone Nov 3, 2022
@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 4, 2022

As dev team lead I approve this compensation request for dev. Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@alvasw Do you have an idea how far we are away from getting Bisq 2 production ready with Bisq easy?

@alvasw
Copy link
Author

alvasw commented Nov 7, 2022

@ripcurlx I'll PMed you a more detailed list. We're mostly feature complete. Chimp implemented almost everything before he left. I'm at the moment, verifying that Bisq 2 is working on all operating systems.

A rough roadmap/todo-list:

  • There have been bugs that were only present on certain OSes. Linux and Windows work now. I'll test soon everything on macOS.
  • We need a wallet UI, the current one sucks. It was a prototype for Bitcoin Core and Liquid.
  • Look DDOS protection (chimp implemented this already, and it should work)
  • Properly initialize and manage Tor
  • Maybe I2P. c4talys7 used to work on I2P, but he left the project. It would be good to have I2P as a backup for Tor, but we could launch initially without it.
  • Review the crypto code and if it's not too much work switch to Noise Framework (used by WhatsApp, WireGuard, Lightning, I2P, ...) instead of relying on our custom crypto.

@alvasw
Copy link
Author

alvasw commented Nov 7, 2022

9c97dce81b2501ebf9a8e51216719996f1c2e8579518cb6a4993dcc34e69f499

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

Issuance by Team:

team amount BSQ amount USD
dev 8000.00 6000.00

Total Issuance: 8000.00 BSQ (equivalent to: 6000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Nov 17, 2022

Closed as acceped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants