Generalize binary downloader/verifier #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new generic download task can download any file and can check its SHA-256 checksum (optional). The signature verifier can be used for any file now. This allows us to reuse the tasks to download the Tor binaries later. Other changes: Currently, all Electrum binaries get zipped and moved to the app resources. This okay until we decided to unpack the Electum.app file at build time. To build the macOS version we require macOS as the host operating system now. Fixes bisq-network#561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new generic download task can download any file and can check its SHA-256 checksum (optional). The signature verifier can be used for any file now. This allows us to reuse the tasks to download the Tor binaries later.
Other changes:
Currently, all Electrum binaries get zipped and moved to the app resources. This okay until we decided to unpack the Electum.app file at build time. To build the macOS version we require macOS as the host operating system now.
Fixes #561