Permit listening to version messages #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps an erronious protocol exception from being thrown if an alert message is received before a version message is received. Fixes bisq-network/bisq#4080
dmos62
commented
Feb 4, 2021
| // No further communication is possible until version handshake is complete. | ||
| if (!(m instanceof VersionMessage || m instanceof VersionAck | ||
| // Most further communication isn't possible until version handshake is complete. | ||
| if (!(m instanceof VersionMessage || m instanceof VersionAck || m instanceof AlertMessage |
There was a problem hiding this comment.
See commit message: 42b32f6 This is a bugfix. Since we've updated to BitcoinJ 15.8, I'm not aware of problems that this bug causes at this time. So this is not strictly related to the PR; however, I think we might as well fix it. Also, I fixed the above comment, since it's in conflict with the next line.
|
Could @chimp1984 or @stejbac review this PR who more familiar with the bitcoinj code? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the porting of PR #35 to BitcoinJ 15.8. I'll copy-paste the general description:
Practically no code changes were required to apply this to 15.8. I copy-pasted the changes one by one anyway to make sure, hence different set of commits.