Our BitcoinJ fork sometimes fails to connect because of deprecated BTC alert system #4080
Labels
Comments
|
Yeah, it also reproduces if you |
dmos62
added a commit
to dmos62/bitcoinj
that referenced
this issue
Feb 3, 2021
This keeps an erronious protocol exception from being thrown if an alert message is received before a version message is received. Fixes bisq-network/bisq#4080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some cases BitcoinJ throws a
ProtocolException, crashing the connection, because it receives an alert message during the handshake [0]. The alert message is sent because Bitcoin Core >= 0.14.0 is telling us to upgrade to atleast version 70012 [1][2].It would be difficult to predict the consequences of changing the advertised version. We could just have BitcoinJ always ignore alert messages (which are deprecated and only useful/used for locking out very old clients). It seems that our fork already is attempting to do that, and the handshake case is an oversight.
I've discovered this when testing a local Bitcoin node that is set to prune. So far this is the only setup where I've received an alert message during handshake. I couldn't discover why.
[0] https://github.com/bisq-network/bitcoinj/blob/bisq_0.14.7/core/src/main/java/org/bitcoinj/core/Peer.java#L474
[1] bitcoin/bitcoin@8ff8d21
[2] https://en.bitcoin.it/wiki/Alert_system
The text was updated successfully, but these errors were encountered: