Remove legacy BSQ altcoin trading #7016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
|
@alvasw pls review. |
alvasw
suggested changes
Feb 26, 2024
There was a problem hiding this comment.
NACK
All BSQ Altcoin offers stay online, can be taken, and funds stay locked.
Test Scenario
- Create legacy BSQ Altcoin accounts for Alice and Bob on v1.9.14
- Create BSQ Altcoin offers on Alice's client
- Update Alice's client to PR code
- Take Alice's BSQ Altcoin offer from Bob's (v1.9.14) client
- Alice's shows "offer was taken" UI and both parties can complete trade as usual
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7011 requested by @refund-agent2
removefilter legacy BSQ altcoin accounts.