Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy BSQ trading protocol #7011

Closed
refund-agent2 opened this issue Jan 26, 2024 · 3 comments
Closed

Remove legacy BSQ trading protocol #7011

refund-agent2 opened this issue Jan 26, 2024 · 3 comments

Comments

@refund-agent2
Copy link

Description

BSQ swaps are a quicker and cheaper option to trade BSQ. Leaving the old trading protocol becomes a possible confusion for traders and leaves a door open for bugs.

I suggest that from now on, only swaps should be allowed to trade BSQ.

Expected behaviour

Traders should not be able to create BSQ accounts, or take multisig BSQ offers.

@jmacxx Could you take a look at this?

@ghost
Copy link

ghost commented Jan 29, 2024

First implementation of this in #7016 was to automatically delete any BSQ altcoin accounts. It took care of most of the use-cases that needed fulfilling in a simple and easy to implement way. Do you think that is the right way to go, or is it too aggressive? I'm not sure if BSQ altcoin accounts may be seen as a user's property and thus not a good idea to delete.

An alternative might be to hide BSQ altcoin accounts from anywhere in the app they are used, such as create offer, take offer, edit offer, duplicate offer, clone offer etc.

I've moved the PR to draft for now.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented May 6, 2024

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant