Refactor & simplify fee service. #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2023 15:10
Use fees retrieved from getAllMarketPrices. More frequent fee updates (was 5 minutes, now 1). Saves one socket connection. Saves one threadpool. Service failover to new node works (previously did not). Uses POJO data transfer object instead of parsing Json in a tree. Code footprint is reduced. Clients no longer need to request fee updates. See issue 5509.
Obsolete async requests removed, replaced by getTxFee().
ghost
requested a review
from 
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the FeeService interface remains unchanged to make this PR easy to read; a further PR couldclean up client calls as an async/blocking interface is not needed. (-> 6b42bb9)Fixes #5509