Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When chosen fee provider is down, Bisq should failover to a new one #5509

Closed
ghost opened this issue May 18, 2021 · 1 comment · Fixed by #6931
Closed

When chosen fee provider is down, Bisq should failover to a new one #5509

ghost opened this issue May 18, 2021 · 1 comment · Fixed by #6931

Comments

@ghost
Copy link

ghost commented May 18, 2021

The Bisq FeeService should automatically select a new provider when the chosen RPC endpoint is down. It does not, simply keeps querying the same one and writing errors to the log. Users are left using stale fee rate (or the default: 50 sat/vB if the server was down at Bisq startup).

PriceFeedService has an automatic failover which chooses a new provider.

PriceFeedService and FeeService could be redesigned to share the same provider and failover mechanism. This would have the added benefit of opening one less connection (currently each Bisq client simultaneously connects to two separate PriceNodes).

@ghost
Copy link
Author

ghost commented Jun 4, 2021

@wiz suggestion: add mempool fees to the getAllMarketPrices endpoint. This will enable a single request from Bisq clients to process market prices and mempool fees. Benefits: better network efficiency & more frequent mempool fee updates (every minute instead of every 5 minutes). PR to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant