Add mempool fees to PriceServer getAllMarketPrices endpoint #5553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #5509, Bisq client has two connections to price nodes: FeeService and PriceFeedService. We can optimize Bisq to use PriceFeedService and obtain both sets of information together which provides the following benefits:
This change is backwards compatible after PriceNodes are updated:
getAllMarketPrices
andgetFees
as before.getAllMarketPrices
data set.This change adds two fields:
bitcoinFeesTs
andbitcoinFeeInfo
togetAllMarketPrices
:This PR only modifies the PriceNode. The idea is to give time to get the PriceNodes upgraded before the Bisq client is rolled out (as noted already, the PriceNode upgrade is compatible with existing Bisq clients).
A separate PR will be created for Bisq clients to make use of this PriceNode optimization.