Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mempool fees to PriceServer getAllMarketPrices endpoint #5553

Merged
merged 1 commit into from Jun 8, 2021
Merged

Add mempool fees to PriceServer getAllMarketPrices endpoint #5553

merged 1 commit into from Jun 8, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2021

As mentioned in #5509, Bisq client has two connections to price nodes: FeeService and PriceFeedService. We can optimize Bisq to use PriceFeedService and obtain both sets of information together which provides the following benefits:

  • Bisq will use one less network connection and make fewer network API calls,
  • corrects the lack of failback mechanism in FeeService,
  • increases the frequency of mempool fee updates 5-fold, at no cost.

This change is backwards compatible after PriceNodes are updated:

  • old clients can still process getAllMarketPrices and getFees as before.
  • new clients can process the additional mempool fee information returned in the getAllMarketPrices data set.

This change adds two fields: bitcoinFeesTs and bitcoinFeeInfo to getAllMarketPrices:

image

This PR only modifies the PriceNode. The idea is to give time to get the PriceNodes upgraded before the Bisq client is rolled out (as noted already, the PriceNode upgrade is compatible with existing Bisq clients).

A separate PR will be created for Bisq clients to make use of this PriceNode optimization.

@ripcurlx ripcurlx added this to the v1.6.6 milestone Jun 7, 2021
@ghost
Copy link
Author

ghost commented Jun 7, 2021

Thanks @KaiWitt changes applied.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit bcabd95 into bisq-network:master Jun 8, 2021
@ghost ghost mentioned this pull request Jul 18, 2021
@ghost ghost deleted the pricenode_feeservice_merge branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants