Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add threadpool for broadcaster #6488

Merged
merged 4 commits into from
Dec 29, 2022
Merged

Add threadpool for broadcaster #6488

merged 4 commits into from
Dec 29, 2022

Commits on Dec 27, 2022

  1. Catch RejectedExecutionException at UncaughtExceptionHandler and log … 

    …error instead calling the uncaughtExceptionHandler

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    e0f4aa2 View commit details
    Browse the repository at this point in the history

  2. Add executor parameter to sendMessage 

    Add try/catch to handle RejectedExecutionException

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    7953e35 View commit details
    Browse the repository at this point in the history

  3. Reduce keepAliveTime to 30 sec. 

    Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    d5b65fe View commit details
    Browse the repository at this point in the history

  4. Add custom thread pool to broadcaster 

    The broadcasting consumes most of the threads but has lower priority than other messages being sent.
By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of
broadcasts exhausts the thread pool and might drop send message tasks.

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    a8a0c0e View commit details
    Browse the repository at this point in the history