Add threadpool for broadcaster #6488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error instead calling the uncaughtExceptionHandler Signed-off-by: HenrikJannsen <[email protected]>
Add try/catch to handle RejectedExecutionException Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
The broadcasting consumes most of the threads but has lower priority than other messages being sent. By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of broadcasts exhausts the thread pool and might drop send message tasks. Signed-off-by: HenrikJannsen <[email protected]>
This was referenced Jan 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6480
At broadcast there can be many messages been sent and if the tor connections are slow the sendMessage threadpool can get exhausted. We did not handle the RejectedExecutionException so it escalated as uncaught exception to the user in from of an error popup (pre 1.9.7 it was swallowed in a debug log, so I assume we had RejectedExecutionException aslo earlier).
We catch now RejectedExecutionException at the sendMessage method as well at the uncaughtExceptionHandler to only log an error but not open an error popup.
We add a dedicated threadpool to the broadcaster so that we can separate that pool from the common sendMessage pool. In case a burst of broadcasts would exhaust the broadcaster pool we get dropped some of the broadcast messages which has little impact and risk. The common sendMessage pool will be not affected in such a scenario, thus important messages like trade messages are not at risk.
We reduced also the keepAliveTime to 30 sec to lower resource comsumption.