Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dao node domain #6418

Merged
merged 5 commits into from
Nov 26, 2022
Merged

Improve dao node domain #6418

merged 5 commits into from
Nov 26, 2022

Commits on Nov 18, 2022

  1. Improve handling of ConnectionState.expectedInitialDataResponses 

    Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    de654c1 View commit details
    Browse the repository at this point in the history

  2. Cleanup comments 

    Improve toString methods
Rename var for more clear meaning

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1e72e26 View commit details
    Browse the repository at this point in the history

  3. Fix bug with using getPreviousBlockHash instead of getHash 

    It had no consequences as it was only used for info logging

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    811ae52 View commit details
    Browse the repository at this point in the history

  4. Improve handling of case when Bitcoin Core sync is not completed. 

    We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0f14ea2 View commit details
    Browse the repository at this point in the history

  5. Cleanup 

    Improve toString methods

Signed-off-by: HenrikJannsen <[email protected]>
    @HenrikJannsen
    HenrikJannsen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    671ab1f View commit details
    Browse the repository at this point in the history