Improve dao node domain #6418
Merged
Improve dao node domain #6418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses. Add comment to make it more clear how its used. Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing). Signed-off-by: HenrikJannsen <[email protected]>
Improve toString methods Rename var for more clear meaning Signed-off-by: HenrikJannsen <[email protected]>
It had no consequences as it was only used for info logging Signed-off-by: HenrikJannsen <[email protected]>
We repeat with a quadratically increasing delay 5 times, then we give up. In the previous code we repeated forever which could be risky in case that code branch is called unexpectedly. Signed-off-by: HenrikJannsen <[email protected]>
Improve toString methods Signed-off-by: HenrikJannsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.