SEPA Account - editable account name and accepted countries

[ghost]

Video:

Fixes #5692

[ripcurlx]

@xyzmaker123 Did you try out what happens when you do this on an already signed account? I fear that this will invalidate the account signing state as it changes the hash as well.

[ghost]

@ripcurlx I didn't tried it on an already signed account - I don't know how to invoke this scenario on localnet dev setup. IIUC acceptedCountries are not used for hash calculation - only iban, bic, countryCode and paymentMethodId

[ghost]

Edge case scenario I tested:

1. Bob has single SEPA account, and accept trades from AT and DE
2. Alice has single SEPA account, and "country of bank set" to DE
3. Bob created offer to buy BTC with euro
4. Alice accepted this offer
5. Bob removed DE from list of accepted countries
6. Alice and Bob were able to finish transaction
   Accepted countries are checked in time of taking offer, there is no check later

[pazza83]

Hi @xyzmaker123 if this is possible it would be great. SEPA countries have changed over the last 12 months (more have been added) so it would be good for accounts set up prior to this to be able to add more countries they are happy to trade with.

I would also propose they should also be able to edit the 'account name' as essentially this is just the nickname given to the account and only used by the users local Bisq instance.

[ghost]

@pazza83 This pull request support this case. These countries are unchecked when someone open edit account, and it's possible to check them.

Sure - I'll extend this pull request with possibility to edit the 'account name' (CC: @ripcurlx)

[ripcurlx]

Hi @xyzmaker123 if this is possible it would be great. SEPA countries have changed over the last 12 months (more have been added) so it would be good for accounts set up prior to this to be able to add more countries they are happy to trade with.

I would also propose they should also be able to edit the 'account name' as essentially this is just the nickname given to the account and only used by the users local Bisq instance.

Just to make sure: In this PR the SEPA countries are not extended/changed:

• getAllSepaEuroCountries: "AT", "BE", "CY", "DE", "EE", "FI", "FR", "GR", "IE","IT", "LV", "LT", "LU", "MC", "MT", "NL", "PT", "SK", "SI", "ES", "AD", "SM", "VA"
• getAllSepaNonEuroCountries:"BG", "HR", "CZ", "DK", "GB", "HU", "PL", "RO","SE", "IS", "NO", "LI", "CH", "JE"

[ripcurlx]

ACK - Tested it on Regtest.

• with signed account, where countries were changed --> account still signed
• created offer with account, changed countries afterwards, created another offer --> both offers/trades are valid as countries are part of the offer and won't be changed at a later stage

[bisq-github-admin-3]

I'm still merging this PR although as Codacy has permission issues (again)

[Bl5ckj5ck]

Great job @xyzmaker123 ! Thanks

[pazza83]

Hi @xyzmaker123 thanks for this. Does this also work for SEPA Instant? Apologies just thought of this now :)

[ghost]

@pazza83 Yes - I also included SEPA Instant accounts during implementation