Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to modify accepted countries #5692

Closed
Bl5ckj5ck opened this issue Sep 12, 2021 · 7 comments · Fixed by #5930
Closed

Not possible to modify accepted countries #5692

Bl5ckj5ck opened this issue Sep 12, 2021 · 7 comments · Fixed by #5930

Comments

@Bl5ckj5ck
Copy link

Description

Hey guys👋 I’ve noticed that once I create a payment method (bank transfer) I can’t then modify the list of accepted countries other than by deleting it.

Version

1.7.3

Steps to reproduce

Create a payment method which involves bank transfers (like SEPA)

Idea

Of course there are some important info defining the details of the payment method that should not be changed in order to prevent the workaround of the “account signing” functionality. Indeed, this avoids that a user could wait for the signing of a payment method and then change its info.

However, I think that the the modification of the “accepted countries” field does not pose a risk in this sense. Thus, what about adding an option to modify this field so that there’s not need delete and recreate the payment method?

This would allow users to change their preferences in case they want to limit/change countries from which they can receive payments.

Hope you find this idea helpful. Please let me know what you think about it

@pazza83
Copy link

pazza83 commented Sep 14, 2021

Thanks @Bl5ckj5ck

I agree with your suggestion.

Also think users should be able to change the "Account Name" the one shown locally as their own account name in Bisq as this also posing no risk as it is not shared with other traders.

@pazza83
Copy link

pazza83 commented Sep 14, 2021

Also recently a few extra SEPA countries / IBANs were added but it is not backwards compatible so allowing users to add in the new countries would be good.

@pazza83
Copy link

pazza83 commented Sep 25, 2021

Hi @xyzmaker123 is this something you could look into?

@ghost
Copy link

ghost commented Sep 28, 2021

@pazza83 How it should be solved from UI/UX perspective? Should we add some "Save changes" button?

@pazza83
Copy link

pazza83 commented Oct 2, 2021

Yes a save changes button would be good

@Bl5ckj5ck
Copy link
Author

Bl5ckj5ck commented Oct 13, 2021

Any update on this @xyzmaker123 ?
@pazza83

@ghost
Copy link

ghost commented Dec 3, 2021

@Bl5ckj5ck I'm planning to work on it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants