Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow standard mark & copy functionality for displayed text fields #5747

Merged
merged 2 commits into from Oct 12, 2021
Merged

Allow standard mark & copy functionality for displayed text fields #5747

merged 2 commits into from Oct 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2021

Instead of a "Copy" icon on every field, allow the text to be selected & copied. Replace addConfirmationLabelLabel with addConfirmationLabelTextField.

  • Gives the ability to mark & copy all text fields in Trade and Dispute tickets.
  • Gives the ability to mark & copy text from TextFieldWithIcon

Resolves #5706


Screenshots:

image

image

image

image

@ghost ghost marked this pull request as ready for review October 11, 2021 19:14
@ripcurlx
Copy link
Contributor

I do agree that it is better to stick to common expected UI features compared to adding more copy icons to do such task.
For completeness this also affects the state string in step 3 on buyer side.
Bildschirmfoto 2021-10-12 um 10 25 38

I've pushed one little logger fix as well, that was introduced by mistake and popped up while searching for references.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@BtcContributor
Copy link
Contributor

I noticed that in the trade detail window if you try to right click on "green" strings like all the txid to copy them, the context menu will open but then instantly it is opened also the mempool.space link.

I know that a user should use the copy button but maybe we could block right click on strings that already have a copy button?

@ghost ghost deleted the display_fields_allow_mark_copy branch May 29, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants