DAO and Fund section in Bisq seems to be missing ability to copy links

[pazza83]

Description

A minor annoyance of mine but the whole DAO and Fund section in Bisq seems to be missing ability to copy links.

Links all have a little link icon. They all seem to be missing the little copy icon.

This is most annoying when doing a transaction and then providing the Tx ID. Currently I users have to visit the website and then copy the Tx ID from the URL or the webpage. It would be much easier if users could just press the little 'copy icon'. It would also reduce the risk of user less error,

Version

v1.5.9

Steps to reproduce

Go to the DAO section is Bisq (No option to copy links in multiple sections)
Go to the Funds section is Bisq (No option to copy links in multiple sections)

You can copy from places such as Trade ID details screen

Expected behaviour

Go to the DAO section is Bisq (option to copy links in multiple sections)
Go to the Funds section is Bisq (option to copy links in multiple sections)

Use the same icon as in the Trade ID details screen

Screenshots

No option to copy Tx ID

No option to copy Tx Id or GitHub issue

[BtcContributor]

I can take care of this.

[BtcContributor]

Update: I had several testing to do for Bisq and other fixes but I already started with this.
It will be released ASAP.

[pazza83]

Hi @BtcContributor how are you progressing with this issue?

[BtcContributor]

Hi @pazza83,
unfortunately this is stuck at this moment as I had other tasks to do.

Btw, I am honestly having some issues implementing the fix, so if this is high priority please assign it to someone else.

[pazza83]

Hi @BtcContributor thanks for letting me know.

@xyzmaker123 let me know if you would like to work on this issue.

[ghost]

@pazza83 There is no "copy" button there, but links are clickable (after click browser with btc/bsq explorer is opened). Isn't it enough?

[pazza83]

Hi @xyzmaker123 the copy button is more secure, private and user friendly.

When trying to get transaction IDs you are forced to open a new window with a blockchain explorer and then copy the transaction ID from that site. This has some privacy concerns and creates a second point of error that you are copying the transaction id from a 3rd party website not from within your Bisq app.

[ripcurlx]

Hi @xyzmaker123 the copy button is more secure, private and user friendly.

When trying to get transaction IDs you are forced to open a new window with a blockchain explorer and then copy the transaction ID from that site. This has some privacy concerns and creates a second point of error that you are copying the transaction id from a 3rd party website not from within your Bisq app.

But you are asked the first time you click on such link if you just want to copy them or open them within a browser.

[ghost]

@ripcurlx Got it - just wanted to be sure everybody agree we want this feature.

[ripcurlx]

The problem I see with this feature request is the concrete implementation part. ATM there is the icon for the link, which is used everywhere in the client. When we want to introduce the copy icon, where should it be? Next to the link icon would be confusing IMO.

[pazza83]

Hi @ripcurlx

Maybe having the transaction IDs selectable / copy-able as per @jmacxx's solution here #5747 would work.

Main issue is trying to navigate the DAO > Wallet > Transaction information none of the text is able to be selected.