Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more offer & contract detail to CLI #5357

Merged
merged 12 commits into from
Apr 2, 2021

Commits on Mar 25, 2021

  1. Add api method createcryptopaymentacct

    This change supports creation of BSQ BLOCKCHAIN payment method accounts.
    
    - Added proto message defs to grpc.proto.
    - Added grpc server boilerplate to GrpcPaymentAccountsService.
    - Added server impl to CoreApi, CorePaymentAccountsService.
    - Added createcryptopaymentacct-help.txt.
    - Added CLI side support for new api method.
    - Added opt parsing unit tests to OptionParsersTest.
    
    This is the 1st PR in a series, with the goal of supporting the BTC/BSQ trading
    pair.  Support for other crypto currency payment accounts will be added later.
    ghubstan committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    c3f5669 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27b0900 View commit details
    Browse the repository at this point in the history
  3. Provide more offer & contract detail available to CLI.

    This change adds offer and trade contract detail to the API's Offer
    and Trade protos, and improves CLI output formatting.
    
    - Appended missing fields to OfferInfo proto message:
    	uint64 sellerSecurityDeposit = 20;
    	string offerFeePaymentTxId = 21;
    	uint64 txFee = 22;
    	uint64 makerFee = 23;
    
    - Added new api proto messages ContractInfo and PaymentAccountPayloadInfo.
      Lighterweight protos are needed because core Trade/Contract classes are
      not visible to CLI.
    
    - Appended ContractInfo field to api proto message TradeInfo.
    
    - Added proto / model converters for ContractInfo and PaymentAccountPayloadInfo,
      and adjusted OfferInfo & TradeInfo.
    
    - Improved CLI output formatting.  Added more trade detail to CLI's gettrade output,
      and prepared to support BTC/BSQ trading pair.  Note a reviewer is advised to
      look at the CLI outout formatting class files instead getting bogged down in the
      many commit changes.
    ghubstan committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    9e035e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Adjust maker gettrade output checks to new column

    The number of gettrade output columns are the same for makers and takers.
    ghubstan committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    780be1a View commit details
    Browse the repository at this point in the history
  2. Remove unused parameter

    ghubstan committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    152f459 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Configuration menu
    Copy the full SHA
    aad998c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    2d66a59 View commit details
    Browse the repository at this point in the history
  2. Add support for creating instant altcoin payment accounts in api

    - Added bool tradeInstant field to proto message def.
    - Adjusted core createcryptopaymentacct impl to new tradeInstant request param.
    - Adjusted cli side createcryptopaymentacct impl to new tradeInstant request param.
    - Fixed CliMain's takeoffer help text (was missing the --payment-account opt).
    ghubstan committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    58c885e View commit details
    Browse the repository at this point in the history
  3. Remove space char

    ghubstan committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    4fbdc32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6299dc3 View commit details
    Browse the repository at this point in the history
  5. Improve takeoffer output and failure reason messaging

    - Added AvailabilityResultWithDescription proto for better takeoffer failure msgs.
    - Added VerifyBsqSentToAddress impl to api, but don't expose to CLI yet.
    - Show BSQ Buyer Address in gettrade output (changed cli output formatting classes).
    - Fixed api.model.PaymentAccountPayloadInfo altcoin instant acct support bug
    ghubstan committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    6bde12b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Fix spelling

    ghubstan committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    bddc273 View commit details
    Browse the repository at this point in the history