Provide more offer & contract detail to CLI #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supports creation of BSQ BLOCKCHAIN payment method accounts. - Added proto message defs to grpc.proto. - Added grpc server boilerplate to GrpcPaymentAccountsService. - Added server impl to CoreApi, CorePaymentAccountsService. - Added createcryptopaymentacct-help.txt. - Added CLI side support for new api method. - Added opt parsing unit tests to OptionParsersTest. This is the 1st PR in a series, with the goal of supporting the BTC/BSQ trading pair. Support for other crypto currency payment accounts will be added later.
This change adds offer and trade contract detail to the API's Offer and Trade protos, and improves CLI output formatting. - Appended missing fields to OfferInfo proto message: uint64 sellerSecurityDeposit = 20; string offerFeePaymentTxId = 21; uint64 txFee = 22; uint64 makerFee = 23; - Added new api proto messages ContractInfo and PaymentAccountPayloadInfo. Lighterweight protos are needed because core Trade/Contract classes are not visible to CLI. - Appended ContractInfo field to api proto message TradeInfo. - Added proto / model converters for ContractInfo and PaymentAccountPayloadInfo, and adjusted OfferInfo & TradeInfo. - Improved CLI output formatting. Added more trade detail to CLI's gettrade output, and prepared to support BTC/BSQ trading pair. Note a reviewer is advised to look at the CLI outout formatting class files instead getting bogged down in the many commit changes.
ghubstan
changed the title
The number of gettrade output columns are the same for makers and takers.
- Added bool tradeInstant field to proto message def. - Adjusted core createcryptopaymentacct impl to new tradeInstant request param. - Adjusted cli side createcryptopaymentacct impl to new tradeInstant request param. - Fixed CliMain's takeoffer help text (was missing the --payment-account opt).
- Added AvailabilityResultWithDescription proto for better takeoffer failure msgs. - Added VerifyBsqSentToAddress impl to api, but don't expose to CLI yet. - Show BSQ Buyer Address in gettrade output (changed cli output formatting classes). - Fixed api.model.PaymentAccountPayloadInfo altcoin instant acct support bug
sqrrm
reviewed
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds offer and trade contract detail to the API's Offer and Trade protos, and improves CLI output formatting.
Appended missing fields to
OfferInfoproto message:uint64 sellerSecurityDeposit = 20;
string offerFeePaymentTxId = 21;
uint64 txFee = 22;
uint64 makerFee = 23;
Added new api proto messages
ContractInfoandPaymentAccountPayloadInfo.Lighterweight protos are needed because core Trade/Contract classes are not visible to CLI.
Appended
ContractInfofield to api proto messageTradeInfo.Added proto / model converters for
ContractInfoandPaymentAccountPayloadInfo, and adjustedOfferInfo&TradeInfo.Improved CLI output formatting. Added more trade detail to CLI's
gettradeoutput, and prepared to support BTC/BSQ trading pair. Note a reviewer is advised to look at the CLI outout formatting class files instead getting bogged down in the many commit changes.This is the 2nd PR in a series, with the goal of supporting the BTC/BSQ trading pair.
PR #5356 must be reviewed/merge before this one.