Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix length check text on manual payout tool #5223

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Fix length check text on manual payout tool #5223

merged 1 commit into from
Feb 24, 2021

Conversation

BtcContributor
Copy link
Contributor

Fix the test displayed on the manual payout check tool.

Before it used everywhere the text The length must be between X and Y.

bisq

P.S.
This is my first PR, so let me know if everything is ok.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 23, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

ghost
ghost suggested changes Feb 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree that adding a third variable is appropriate.
Can do the same functionality by checking minLength==maxLength.

ghost
ghost previously approved these changes Feb 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ACK

@ripcurlx ripcurlx added this to the v1.6.0 milestone Feb 24, 2021
ripcurlx
ripcurlx approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #5223 (review)

@ripcurlx ripcurlx merged commit 0feb107 into bisq-network:master Feb 24, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 24, 2021

Awesome work, congrats on your first merged pull request!

@BtcContributor BtcContributor deleted the lengthcheck branch February 24, 2021 09:34
@BtcContributor BtcContributor mentioned this pull request Feb 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BtcContributor @ripcurlx