Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 22 #786

Closed
BtcContributor opened this issue Feb 27, 2021 · 4 comments
Closed

For Cycle 22 #786

BtcContributor opened this issue Feb 27, 2021 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@BtcContributor
Copy link

BtcContributor commented Feb 27, 2021

Hi all,
this is my first CR so I hope I did not make any mistake.

I started this journey 10 days ago and I would like to help this project as much as my time and skills will allow me.

Summary

  • BSQ requested: 371.90
  • USD requested: 450
  • BSQ rate: 1.21 USD per BSQ

Contributions delivered

Title Team USD Link Notes
Testing dev 400 Test reports for v1.5.7 for Cycle 22.
Fix length check text on manual payout tool dev 50 bisq-network/bisq#5223

My first work was about Testing the new 1.5.7 release.
I was introduced to this task by @ripcurlx and I executed all the Trading, Mediation and Arbitration test suites + others on Windows 10.
I found this issue that seems to be pretty important.
Also to that I tested the following 3 issues that were outside the test suites, as requested by the dev team leader, and reported the results on Keybase:

Then I started to deep dive in the code and tried to patch as many bugs as possible.

Contributions in progress

I am waiting for the review and eventual merge of the following PRs (I am adding to them day by day to keep track for future cycles):

I am working right now on this issue and a couple of others:

I also started a review of all the dev documentations and I am planning to release some improvements soon, as it is a bit outdated. This could help a more easier onboarding for all the future devs as well.

I also started the API testing and related PR reviews under the guide of @ghubstan.
I already found a couple of little bugs here:

I am glad to be part of your team!

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Feb 27, 2021
@MwithM MwithM added this to the Cycle 22 milestone Feb 28, 2021
@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 4, 2021

Welcome to Bisq @BtcContributor! Thanks especially for your testing support! As team lead I approve this request for dev.

@BtcContributor
Copy link
Author

TxID: 4e280bcd7aaab510b287799e74fec23c371076cd08899757a1b0587fca0baf86

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 15, 2021
@ghost
Copy link

ghost commented Mar 15, 2021

Issuance by Team:

team amount BSQ amount USD
dev 371.90 450.00

Total Issuance: 371.90 BSQ (equivalent to: 450.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Mar 15, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants