Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword "trade started" popup messages per suggestion #5091

Merged
merged 2 commits into from Jan 19, 2021
Merged

Reword "trade started" popup messages per suggestion #5091

merged 2 commits into from Jan 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2021

This PR implements @m52go's suggested simplification.

^ there is a lot of text on this screen...this reduces the chance that the user reads any of it.
I'm not sure the parts on multiple confirmations, bank details, copy/paste, etc. are that important.
Suggestion to simplify:

Your trade has reached at least 1 blockchain confirmation.
Please pay 303 EUR via the specified payment method to the BTC seller. You'll find the seller's account details on the next screen.
Important: when making the payment, leave the "reason for payment" field empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'.
If your bank charges you any fees to make the transfer, you are responsible for paying those fees.

#5080 (comment)

And

I agree, but I would prefer to keep that for another PR. There are more popup text to improve but as the text is composed of several blocks depending on payment method its also not that trivial and need then better testing with the diff. payment methods.
Any dev who wants to pick that up?

#5080 (comment)


Here is a set of screenshots showing how each popup looks: trade_popups.pdf. It includes FasterPayments, Cash Desposit, Moneygram, HalCash, Altcoins, F2F, Zelle, Transferwise, Amazon, USPSMO, Sepa.

Here's one example:
image


Please note I had to implement on PR #5080, so those commits are also included here. I presume #5080 will be merged prior to this. Hopefully git will handle things intelligently.

@Conza88
Copy link

Conza88 commented Jan 18, 2021

Typo for “youll”.

I’d also be keen to have: #5080 (comment)

@ghost
Copy link
Author

ghost commented Jan 19, 2021

image
@m52go 👆
@Conza88 thanks for finding the typo.

@ghost ghost mentioned this pull request Jan 19, 2021
@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 19, 2021
@ripcurlx ripcurlx changed the base branch from master to hotfix/v1.5.4 January 19, 2021 09:26
@ripcurlx ripcurlx changed the base branch from hotfix/v1.5.4 to master January 19, 2021 09:26
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 3f5c455 into bisq-network:master Jan 19, 2021
@ghost ghost deleted the test2 branch January 24, 2021 16:23
@ghost ghost mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants