Reword "trade started" popup messages per suggestion #5091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements @m52go's suggested simplification.
#5080 (comment)
And
#5080 (comment)
Here is a set of screenshots showing how each popup looks: trade_popups.pdf. It includes FasterPayments, Cash Desposit, Moneygram, HalCash, Altcoins, F2F, Zelle, Transferwise, Amazon, USPSMO, Sepa.
Here's one example:
Please note I had to implement on PR #5080, so those commits are also included here. I presume #5080 will be merged prior to this. Hopefully git will handle things intelligently.