Change rule for "reason for payment" field to not use trade ID but leave it empty #5080
Conversation
State to use empty field instead.
|
|
|
@m52go Could you have a look to the text changes? |
|
REALLY think if this is going ahead to advise or push folks to continue discussing in chat with trading partner. That's the important part. Communication. There's no indication anywhere why this change is being made either. It will likely make life harder for extensive traders, no? That's not ideal. They'd want to know WHY this sudden change. I think stating clearly the rationale would help immensely. Obviously the high volume traders are more at risk getting banned as well, so should support a move that lessens that. |
desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java
Outdated
Show resolved
Hide resolved
|
^ there is a lot of text on this screen...this reduces the chance that the user reads any of it. I'm not sure the parts on multiple confirmations, bank details, copy/paste, etc. are that important. Suggestion to simplify: Your trade has reached at least 1 blockchain confirmation. Please pay 303 EUR via the specified payment method to the BTC seller. You'll find the seller's account details on the next screen. Important: when making the payment, leave the "reason for payment" field empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'. If your bank charges you any fees to make the transfer, you are responsible for paying those fees. |
|
Nice. Is there a potential wiki link if someone is new, or old school and wants to know more? Something that may cover why we're no longer suggesting putting in trade ID? It's a massive step from MUST have trade ID, to DO NOT.
Added: "(i) This is to reduce the risk of fiat accounts being deactivated or banned. You are free to discuss via trader chat if an alternate 'trade ID' would be suitable to you both." Ideally the (i) only appears when hovered over, not sure if can be done in popup. |
Co-authored-by: m52go <[email protected]>
Co-authored-by: m52go <[email protected]>
…ndow.java Co-authored-by: m52go <[email protected]>
I agree, but I would prefer to keep that for another PR. There are more popup text to improve but as the text is composed of several blocks depending on payment method its also not that trivial and need then better testing with the diff. payment methods. Any dev who wants to pick that up? @m52go Can you check if there are reference on the webpage or other resources regarding that fields? |
Yes I agree, but I think in the app we should keep things minimal and that context is only relevant for existing users not for new users. Maybe @m52go has a suggestion how to communicate best the reason for the change. To add a sentence to the popup at startup might be ok as well, as its only shown to existing users. |
Yes I'll check. There are probably some spots on the wiki, not sure about website. |
|
utACK. What about i18n versions of these messages? Is the process tight enough there to ensure we get translations (for the most important languages) coordinated with this release? |
|
When is the next release expected? cc @MwithM |
|
"I'm concerned that it might be an issue that some banks / payment providers will require a non-empty 'reason for payment' field."
I think this is also very likely. There's value in recen advising traders discuss what could be used imo.
________________________________
From: Chris Beams <[email protected]>
Sent: Friday, 15 January 2021, 17:51
To: bisq-network/bisq
Cc: Conza; Comment
Subject: Re: [bisq-network/bisq] Change rule for "reason for payment" field to not use trade ID but leave it empty (#5080)
@cbeams commented on this pull request.
________________________________
In core/src/main/resources/i18n/displayStrings.properties<#5080 (comment)>:
@@ -637,12 +636,9 @@ portfolio.pending.step1.openForDispute=The deposit transaction is still not conf
portfolio.pending.step2.confReached=Your trade has reached at least one blockchain confirmation.\n(You can wait for more confirmations if you want - 6 confirmations are considered as very secure.)\n\n
portfolio.pending.step2_buyer.copyPaste=(You can copy & paste the values from the main screen after closing that popup.)
-portfolio.pending.step2_buyer.refTextWarn=DO NOT use any additional notice in the \"reason for payment\" text like bitcoin, BTC or Bisq.
+portfolio.pending.step2_buyer.refTextWarn=Leave the \"reason for payment\" field empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'.
As I mentioned in Keybase, I'm concerned that it might be an issue that some banks / payment providers will require a non-empty 'reason for payment' field. We can wait and see if this is actually a problem, but just a heads-up that it might be.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#5080 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMLWYQ7GT3ZOWG6ONFHV33SZ7XXTANCNFSM4WB3AZAQ>.
|
|
Sorry, I missed this. I had a look at the text and it all looks great to me. I am sure there will be some teething issues with traders using trade ID as payment references but these will quickly be sorted out and the odd trader using them until informed otherwise does not seem like much, if any, risk. I agree the Wiki / website needs to ensure that it is edited to include the new trade protocol. I will contact @m52go on Keybase about what is needed and agree a plan. |
Implements #2869
Hope I did not missed some...
@m52go @pazza83 I am not 100% sure if the popup at startup is enough to announce the change. I think we should additionally communicate it clearly in all our channels and of course to our support guys.