Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for hiding not takable offers #5048

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Jan 2, 2021

Adds a toggle to the offer book views to filtering offers which can be taken from users accounts. It uses the same code which is used for the disable state for take offer buttons, so all the greyed out offers are hidden if toggle is selected. It can be combined with the other 2 dropbox filters.

We cache some method results for performance reasons. This also improves the performance without selecting the toggle.
#5047 will add more performance improvements which will speed up the first calls to the expensive methods further.

Based on #5045. Commits start at 26c1c0e
Rebased on master.

@chimp1984
Copy link
Contributor Author

Screen Shot 2021-01-02 at 18 38 22

Screen Shot 2021-01-02 at 18 38 30

@chimp1984 chimp1984 force-pushed the add-toggle-for-hiding-not-takable-offers branch from c7e2e3d to f588b22 Compare January 4, 2021 16:33
@chimp1984 chimp1984 mentioned this pull request Jan 4, 2021
@Conza88
Copy link

Conza88 commented Jan 5, 2021

Ha, excellent. Possible to include own offers and show in 'matching my accounts'?
I suspect - yes - that would be wanted? Although not technically 'takeable' (but can action i.e. 'remove') and is kind of their account?

Also - can you filter between what is currently available in your accounts? e.g. toggle is on for 'takeable' / 'matching' ... and you want to only see "Transferwise"? That works?

@ripcurlx ripcurlx merged commit cfabf79 into bisq-network:master Jan 7, 2021
@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 7, 2021
@chimp1984 chimp1984 deleted the add-toggle-for-hiding-not-takable-offers branch January 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants