Add cache for signature verification results and a lookup map by ownerPubKey #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimp1984
force-pushed
the
optimize-signed-witness-domain
branch
from
2cd4bdf to
0ce9324
Compare
|
Epic 👌🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new filter to the offer book it became has shown that there are some performance bottlenecks in the signedWitness domain. With Profiling 2 methods have been found causing the main costs.
Before that optimisation the new filter took about 265 ms (200 ms for the signature checks and 65 ms for the iteration testing for same ownerPubKeys. After the optimisation it is about 15 ms.
This code was also called already by the item renderer for the take offer button to show if it is enabled or not. So the offer book becomes faster as well.