Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show price deviation in % for fixed price offers and BSQ #4949

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Show price deviation in % for fixed price offers and BSQ #4949

merged 5 commits into from
Dec 16, 2020

Commits on Dec 16, 2020

  1. Show also % price deviation for fixed price and 

    sort according to it
Allow sorting at show all. This helps to spot
good offers with negative % over the whole market.
    @chimp1984
    chimp1984 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    f97bb62 View commit details
    Browse the repository at this point in the history

  2. Add price deviation in % to BSQ using 30 day average

    @chimp1984
    chimp1984 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    34f10d3 View commit details
    Browse the repository at this point in the history

  3. Add check to not devide by 0 

    Cleanups
    @chimp1984
    chimp1984 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c858ac7 View commit details
    Browse the repository at this point in the history

  4. Set bsq30DayAveragePrice only at activate as its expensive 

    call and does not change frequently and is only used for
informational purpose as % display.
    @chimp1984
    chimp1984 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1106d01 View commit details
    Browse the repository at this point in the history

  5. Add null check (for tests) and fix missing param for test class. 

    Fix test with price display.
    @chimp1984
    chimp1984 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    bb3dbf3 View commit details
    Browse the repository at this point in the history