Show price deviation in % for fixed price offers and BSQ #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chimp1984
changed the title
sort according to it Allow sorting at show all. This helps to spot good offers with negative % over the whole market.
Cleanups
call and does not change frequently and is only used for informational purpose as % display.
Fix test with price display.
chimp1984
force-pushed
the
show-pricedeviation-for-fixed-price-offers
branch
from
d7690d1
to
bb3dbf3
Compare
|
Travis has problems again... |
|
This is such a good addition 👍 Please can it also be added to the 'Trades' section. Being able to now export the trades section is great, but it would be even better is the deviation could also be exported. An option to filter this section by 'payment method' as well as 'currency' would also be really useful.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add price deviation in % to fix price offers and BSQ (using 30 day average)
Allow sorting by % price in "show all" mode.
There are performance issues in the offer book as we use the view model for the item value calculations and do not cache the values. With those changes here it got worse. So we need to refactor the handling of the ListItem so that the ListItem caches the data and only updates when needed (e.g. when a market price feed update arrives). There will be follow up commits for that.
UPDATE:
The issue was the 30 day average BSQ price which was calculated too frequently. This is fixed now and the table behaves similar like the master version. Still need for performance improvement in that area, but seems that PR does not make things worse.