Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sign age column sortable #4929

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Dec 10, 2020

Add support for sorting by signed account age

We separate in 4 groups and sort each by days.

  1. signed accounts
  2. not yet signed account, we use account age
  3. not required signing, we use account age
  4. no account age and no signing required (altcoins)

Improve logs if trade limit was violated
We separate in 4 groups and sort each by days.
1. signed accounts
2. not yet signed account, we use account age
3. not required signing, we use account age
4. no account age and no signing required (altcoins)
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested it on Regtest

@ripcurlx ripcurlx merged commit f4df51c into bisq-network:master Dec 10, 2020
@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 10, 2020
@chimp1984 chimp1984 deleted the make-sign-age-column-sortable branch December 10, 2020 14:27
@pazza83
Copy link

pazza83 commented Jan 3, 2021

This is great, works really well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants