Offer Book chart outlier filter improved. #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outlier data filter used for the Market Offer Book chart, now accounts for the switching display position of Buy, Sell data depending on currency type (Crypto or Fiat).
ripcurlx
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlier data filter used for the Market Offer Book chart, now accounts
for the switching display position of Buy, Sell data depending on
currency type (Crypto or Fiat).
Fixes #4871
Some of the Market Offers have values far from the main trading body (outliers). Including these points in a chart destroys any significant and useful information presented in the graph. An outlier filter, applied during the production of these charts, is used to remove such points.
The implementation of this filter did not take into account the chart differences between fiat and crypto currencies. The one in this PR does.
The recently increasing Fiat value of BTC, coupled with extreme outlier values, has exposed the limitations. This PR provides a filter that gives better results and should be much more stable.
See issue #4871 for before & after screenshots.