Make CoreApi a singleton #4461
Merged
Make CoreApi a singleton #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The access modifier on CompositeOptionSet was changed to public in commit c402386, to make it visible to the apitest config class. The annotation added in this change concisely explains why the class is not package protected.
Also fixed line length of a comment, and removed two extra white lines.
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures a daemon never creates more than one
CoreApiinstance, but two additional, minor changes are included:Add
@VisibleForTestingannotation toCompositeOptionSetto explain why it is no longer package protected.Remove commented code from
BisqAppMain.