Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user name for Revolut accounts #4453

Merged
merged 3 commits into from
Sep 1, 2020

Commits on Aug 30, 2020

  1. Add support for user name for Revolut accounts

    If a user has an existing account with phone number or email as
    account ID we show a popup at startup where we require that he sets the
    user name. This popup has no close button so he is forced to enter a
    value. If there are multiple account multiple popups will be shown.
    
    To not break signed accounts we keep accountId as internal id used for signing.
    Old accounts get a popup to add the new required field userName but accountId is
    left unchanged. Newly created accounts fill accountId with the value of userName.
    In the UI we only use userName.
    
    Input validation does only check for length (5-100 chars). Not sure what
    are the requirements at Revolut. Can be changes easily if anyone gets
    the specs.
    chimp1984 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    6c60e17 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Revert to use empty string as default for accountId instead of null.

    Prefer to keep old functionality here...
    chimp1984 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    59ebefc View commit details
    Browse the repository at this point in the history
  2. Add comment

    chimp1984 committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    591011e View commit details
    Browse the repository at this point in the history