Add support for user name for Revolut accounts #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has an existing account with phone number or email as account ID we show a popup at startup where we require that he sets the user name. This popup has no close button so he is forced to enter a value. If there are multiple account multiple popups will be shown. To not break signed accounts we keep accountId as internal id used for signing. Old accounts get a popup to add the new required field userName but accountId is left unchanged. Newly created accounts fill accountId with the value of userName. In the UI we only use userName. Input validation does only check for length (5-100 chars). Not sure what are the requirements at Revolut. Can be changes easily if anyone gets the specs.
sqrrm
reviewed
Aug 31, 2020
desktop/src/main/java/bisq/desktop/util/validation/RevolutValidator.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/overlays/windows/UpdateRevolutAccountWindow.java
Show resolved
Hide resolved
Prefer to keep old functionality here...
sqrrm
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has an existing account with phone number or email as
account ID we show a popup at startup where we require that he sets the
user name. This popup has no close button so he is forced to enter a
value. If there are multiple account multiple popups will be shown.
To not break signed accounts we keep accountId as internal id used for signing.
Old accounts get a popup to add the new required field userName but accountId is
left unchanged. Newly created accounts fill accountId with the value of userName.
In the UI we only use userName.
Input validation does only check for length (5-100 chars). Not sure what
are the requirements at Revolut. Can be changes easily if anyone gets
the specs.