Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setUpScaffold() signature #4429

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ghubstan
Copy link
Contributor

Adds the missing String[] params to the method signature, so test cases can pass any needed combination of options to the scaffolding setup from a @BeforeAll method.

PR 1 of 5, to be reviewed/merged in PR number order.

Adds the missing String[] params to the method signature, so test cases
can pass any needed combination of options to the scaffolding setup
from a @BeforeAll method.
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit de56c1e into bisq-network:master Aug 31, 2020
@sqrrm sqrrm added this to the v1.3.8 milestone Aug 31, 2020
@ghubstan ghubstan deleted the 1-add-setup-scaffold-param branch September 1, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants