Add rpc wallet endpoint tests and update version check

[ghubstan]

This commit includes the following changes:

• New tests for methods lockwallet, unlockwallet,
  removewalletpassword, and setwalletpassword.

• New getbalance method error handing tests to verify
  error message correctness when wallet is locked.

• Update to getversion method test -- now expects 1.3.4.

• Check for new [params] column header in help text.

This PR replaces 4243, which had not been kept in sync with commits to tested methods in 4214 .

[ghubstan]

To run the test suite:

(1) Clone and Build

  $ git clone -b add-wallet-protect-method-tests https://github.com/ghubstan/bisq.git add-wallet-protect-method-tests

  $ cd add-wallet-protect-method-tests

  $ ./gradlew clean build -x test

(2) Run the server on Linux or OSX:

  $ ./bisq-daemon --apiPassword=xyz --appDataDir=/tmp/newbisqdatadir

(3) Let the server initialize (sync) for 2+ minutes.

(4) Run the bats test suite:

  $ bats cli/test.sh

All tests should pass.

[sqrrm]

@ghubstan I will leave this for @cbeams to review unless you have an urgent need for me to look at it.

[ghubstan]

@sqrrm , not urgent and not a problem... @cbeams asked me get others (not maintainers) to review this, and there's no rush for them either.

[sqrrm]

@ghubstan If you could find someone else that's interested in this project to do reviews and for you to bounce ideas I think that would be ideal. I follow it but not in detail so it's hard to do the reviews.

[ghubstan]

Closing, will be replaced by new PR off less stale main branch.

[ghubstan]

Replaced by 4296

[cbeams]

You can rebase against master and force push to this PR branch; no need to close and re-create a new PR.

…

On Jun 12, 2020, at 9:29 PM, Stan ***@***.***> wrote:  Closing, will be replaced by new PR off less stale main branch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cbeams]

I didn’t see that the new one had already been created when I wrote the above; just a note for future reference, then.

…

On Jun 13, 2020, at 7:09 AM, Chris Beams ***@***.***> wrote:  You can rebase against master and force push to this PR branch; no need to close and re-create a new PR. >> On Jun 12, 2020, at 9:29 PM, Stan ***@***.***> wrote: >> >  > Closing, will be replaced by new PR off less stale main branch. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or unsubscribe.