Add rpc wallet protection method tests #4243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are meant to be run against rpc methods in PR bisq-network#4214. This change should not be merged before PR bisq-network#4214.
cbeams
suggested changes
May 18, 2020
There was a problem hiding this comment.
NACK. I've just merged #4214, and attempted to merge this as well, but there are a number of test failures. One fragile one is exact string matching on version (it's 1.3.2 in the tests but 1.3.4 on master right now). There are some other failures as well that weren't obvious to me at a glance.
|
Closing. Will create new PR from master with changes merged from #4214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are meant to be run against rpc methods in PR #4214.
This change should not be merged before PR #4214.