Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate expect based rpc test suite to bats #4209

Merged
merged 3 commits into from
May 1, 2020
Merged

Migrate expect based rpc test suite to bats #4209

merged 3 commits into from
May 1, 2020

Conversation

ghubstan
Copy link
Contributor

The bats automated bash testing system is more concise and easier to work with than the older tcl - expect based test program.

@ghubstan ghubstan mentioned this pull request Apr 29, 2020
Merged
cbeams
cbeams approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, with a couple polishing commits added.

@cbeams cbeams merged commit bb2484a into bisq-network:master May 1, 2020
@ghubstan ghubstan deleted the migrate-rpc-test-to-bats branch May 1, 2020 15:27
@ghubstan ghubstan mentioned this pull request May 8, 2020
Closed
@ghubstan ghubstan mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeams cbeams cbeams approved these changes

Assignees

@ghubstan ghubstan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubstan @cbeams