Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 14 #586

Closed
ghubstan opened this issue Jun 17, 2020 · 10 comments
Closed

For Cycle 14 #586

ghubstan opened this issue Jun 17, 2020 · 10 comments
Assignees
Labels
team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Jun 17, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate:

  • BSQ requested: 1984.13
  • USD requested: 1250
  • BSQ rate: 0.63 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 13 #550

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Migrate cli test suites to bats testing system dev 250 bisq-network/bisq#4209 released
Add rpc wallet protection endpoints dev 1000 bisq-network/bisq#4214 released

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Rename CoreWalletService -> CoreWalletsService dev --- bisq-network/bisq#4295 merged
Add wallets protection api tests dev --- bisq-network/bisq#4296 merged
Add rpc method getfundingaddresses dev --- bisq-network/bisq#4299 merged
Add rpc method getaddressbalance dev --- bisq-network/bisq#4304 merged
Add rpc method createpaymentacct dev --- bisq-network/bisq#4308 merged
Call core wallets service methods from CoreApi dev --- bisq-network/bisq#4309 merged
Factor duplicate unlocked wallet checks into new method dev --- bisq-network/bisq#4312 merged
Refactor getfundingaddresses to use memoization dev --- bisq-network/bisq#4322 merged
Add rpc method getpaymentaccts dev --- bisq-network/bisq#4323 merged
Return protos from funding address methods dev --- bisq-network/bisq#4324 merged
Add rpc method getoffers dev --- bisq-network/bisq#4329 merged
@ghubstan
Copy link
Member Author

@jmacxx, I don't know why my table formatting is messed up. Any hint you can give me to get this looking like yours at 583?

@ghubstan
Copy link
Member Author

This request is ready for review.

@ghubstan ghubstan changed the title [WIP] For Cycle 14 For Cycle 14 Jun 17, 2020
@m52go
Copy link

m52go commented Jun 17, 2020

@ghubstan that first line in the table with the dashes is required (I know it's not obvious in the template...will submit a fix shortly).

Concretely, keep this line:
| --- | --- | --- | --- | --- |

And add your items below it.

Also, you don't need brackets around numbers in the summary section.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jun 17, 2020
This was referenced Jun 17, 2020
@MwithM MwithM added this to the Cycle 14 milestone Jun 17, 2020
@ghost ghost mentioned this issue Jun 18, 2020
@sqrrm
Copy link
Member

sqrrm commented Jun 21, 2020

As stand in dev team lead that forgot this is part of the duty I approve this request.

Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ghubstan
Copy link
Member Author

From log: MyProposalListService: Proposal tx has been published.
TxId=8f3943e483aba75aff2b83eb6ec2322f771da0c2b645a2d24e1d7a9f60a296e2

@ripcurlx ripcurlx mentioned this issue Jun 21, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Issuance by Team:

team amount
DEV 1984.13 BSQ

Total Issuance: 1984.13 BSQ (equivalent to: 1250.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Jul 2, 2020

Closed as: accepted

@MwithM MwithM closed this as completed Jul 2, 2020
@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Jul 19, 2020
@ghost
Copy link

ghost commented Jul 19, 2020

Info

Read BSQ amount from summary: 1984.13
Read USD amount from summary: 1250
Read BSQ rate from summary: 0.63
Parsed lineitem: {"team":"DEV","amount":250}
Parsed lineitem: {"team":"DEV","amount":1000}

Errors

Incorrect BSQ rate specified: 0.63, expected: 0.65
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 1984.13 BSQ
  • Calculated total: 1923.08 BSQ

@ghubstan
Copy link
Member Author

Info

Read BSQ amount from summary: 1984.13
Read USD amount from summary: 1250
Read BSQ rate from summary: 0.63
Parsed lineitem: {"team":"DEV","amount":250}
Parsed lineitem: {"team":"DEV","amount":1000}

Errors

Incorrect BSQ rate specified: 0.63, expected: 0.65
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 1984.13 BSQ
  • Calculated total: 1923.08 BSQ

Looks like there is a bot bug because the rate was 0.63 in Cycle 14, not 0.65

@ghubstan ghubstan mentioned this issue Jul 20, 2020
@ghost ghost removed the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Jul 25, 2020
@ghost
Copy link

ghost commented Jul 25, 2020

Thanks, I'll change the bot so it ignores notifications from closed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants