Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing to pricenode cmdline inputs #4112

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add parsing to pricenode cmdline inputs #4112

merged 1 commit into from
Apr 2, 2020

Conversation

freimair
Copy link
Contributor

@freimair freimair commented Apr 2, 2020

Stumbled over during #4027

This PR adds basic input validation and correction for the custom pricenode command line parameter:

  • --help says
  --providers=<host:port[,...]>
        List custom pricenodes
  • yet, setting the value to 44mgyoe2b6oqiytt.onion:80 fails.
  • because the correct formatting requires "http" in front and a "/" at the end

ripcurlx
ripcurlx approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 0a22f46 into bisq-network:master Apr 2, 2020
@ripcurlx ripcurlx added this to the v1.3.0 milestone Apr 2, 2020
@ripcurlx ripcurlx mentioned this pull request Apr 15, 2020
Closed
@freimair freimair deleted the input_parsing branch September 10, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@freimair @ripcurlx