Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report HS version to pricenode #4027

Merged

Conversation

freimair
Copy link
Contributor

@freimair freimair commented Mar 4, 2020

Part of bisq-network/projects#23

In order to evaluate progress on bisq-network/projects#23,
the Bisq app reports its hiddenservice version.

This change is going to be undone as soon as we do not need the
info anymore.

In order to evaluate progress on bisq-network/projects#23,
the Bisq app reports its hiddenservice version.

This change is going to be undone as soon as we do not need the
info anymore.
wiz
wiz previously approved these changes Mar 31, 2020
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - tested on gztmprecgqjq64zh pricenode 👍
suggested change is -days 3650 in the openssl command in install_collectd_debian.sh script

@freimair freimair marked this pull request as ready for review April 1, 2020 15:49
@freimair freimair requested a review from cbeams as a code owner April 1, 2020 15:49
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #4027 (review)

@ripcurlx ripcurlx merged commit 57157c7 into bisq-network:master Apr 2, 2020
@freimair freimair deleted the report_hsversion_to_pricenode branch April 2, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants