Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust NetworkSize metric installer #4004

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Adjust NetworkSize metric installer #4004

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1fc9d0
Adjust the pricenode installer
freimair Feb 24, 2020
ebdff56
Amended pricenode readme
freimair Feb 24, 2020
cfa55df
Align scraper script
freimair Feb 27, 2020
bdc4dec
Apply suggestions from code review
freimair Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pricenode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,21 @@ curl http://localhost:8080/getVersion
curl http://localhost:8080/info
```

### Monitoring

If you run a main pricenode, you also are obliged to activate the monitoring feed by running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These "obligations" should be listed at https://bisq.wiki/Pricenode_Operator#Duties. I've just created that page as a stub. I've asked all @bisq-network/pricenode-operators to watch that page at bisq-network/roles#14 (comment), so changes you make there will have a reasonable chance of being seen by them (duty changes should be communicated and followed up on more explicitly in any case, but FYI the wiki page is there, and we should rally around it).

Copy link
Contributor Author

@freimair freimair Feb 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. however, I do not have the authority to create directives. Creating directives can only be done by

  • the project leader,
  • the team leader of the team that is affected (the ops-team in this case), or
  • the team leader leader

at the time of writing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. By the powers vested in me as Admin team lead, I request that you transcribe what you've written here to the wiki, and as part of the overall delivery of task's parent project bisq-network/projects#13, announce that change to the @bisq-network/pricenode-operators team, and follow up that each operator actually complies. If you're not comfortable doing this, then please manage that @wiz does it in his role as ops team lead. The point is that changes like this are useless unless they're effectively communicated and followed up on. It doesn't mean you have to do the work yourself, but that you own that the work does get done. Updating a readme (or the wiki for that matter) on its own won't carry the day. Feel free to create an admin repo issue or issues about doing this documentation and communication work and request/suggest that @wiz be assigned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the above should not hold up the merging of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated the wiki to add running collectd as a "duty" with link to the README anchor that will exist after this PR is merged


```bash
curl -s https://raw.githubusercontent.com/bisq-network/bisq/master/monitor/install_collectd_debian.sh | sudo bash
```
Follow the instruction given by the script and report your certificate to the seednode group!
freimair marked this conversation as resolved.
Show resolved Hide resolved

Furthermore, you are obliged to provide network size data to the monitor by running
```bash
curl -s https://raw.githubusercontent.com/bisq-network/bisq/master/pricenode/install_networksize_debian.sh | sudo bash
```


## How to deploy elsewhere

- [README-HEROKU.md](README-HEROKU.md)
Expand Down
1 change: 1 addition & 0 deletions pricenode/bisq-pricenode.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Description=Bisq Price Node
After=network.target

[Service]
SyslogIdentifier=bisq-pricenode
EnvironmentFile=/etc/default/bisq-pricenode.env
ExecStart=/bisq/bisq/bisq-pricenode 2 2
ExecStop=/bin/kill -TERM ${MAINPID}
Expand Down
2 changes: 1 addition & 1 deletion pricenode/journalscraper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ while true;
do
now=$(date +"%F %T")

journalctl -u bisq --since="$last" --until="$now" | grep -Eo "getAllMarketPrices.*bisq/[0-9].[0-9].[0-9]" | cut -d / -f 2 | sort | uniq -c | while read -r line; do
journalctl -u bisq-pricenode --since="$last" --until="$now" | grep -Eo "getAllMarketPrices.*bisq/[0-9].[0-9].[0-9]" | cut -d / -f 2 | sort | uniq -c | while read -r line; do
number=$(echo "${line}" | cut -d ' ' -f 1);
version=$(echo "${line}" | cut -d \ -f 2);
version=${version//./_};
Expand Down