Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust NetworkSize metric installer #4004

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

freimair
Copy link
Contributor

@freimair freimair commented Feb 24, 2020

followup to #3997, part of bisq-network/projects#13

Tweak the networksize metric scraper script, the pricenode installer and amend the readme on how to use it.

notes to self: cannot make the JVM fire up a jmx-service.

standin jar works

% jcmd 28970 PerfCounter.print
[snip]
java.rt.vmArgs="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.local.only=true -Dcom.sun.management.jmxremote.port=6969 -Dcom.sun.management.jmxremote.rmi.port=6969 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false"
[snip]
sun.management.JMXConnectorServer.0.authenticate="false"
sun.management.JMXConnectorServer.0.remoteAddress="service:jmx:rmi:///jndi/rmi://workstation:6969/jmxrmi"
sun.management.JMXConnectorServer.0.ssl="false"
sun.management.JMXConnectorServer.0.sslNeedClientAuth="false"
sun.management.JMXConnectorServer.0.sslRegistry="false"
sun.management.JMXConnectorServer.address="service:jmx:rmi://127.0.0.1/stub/rO0ABXNyAC5qYXZheC5tYW5hZ2VtZW50LnJlbW90ZS5ybWkuUk1JU2VydmVySW1wbF9TdHViAAAAAAAAAAICAAB4cgAaamF2YS5ybWkuc2VydmVyLlJlbW90ZVN0dWLp/tzJi+FlGgIAAHhyABxqYXZhLnJtaS5zZXJ2ZXIuUmVtb3RlT2JqZWN002G0kQxhMx4DAAB4cHc5AAtVbmljYXN0UmVmMgAADjE5Mi4xNjguOTMuMTAyAACyuWmYcsfkIQJcg+K0sQAAAXB3S81MgAIAeA=="
sun.management.JMXConnectorServer.remote.enabled=0

[snip]

price node does not

root@bisqserver ~ # /usr/lib/jvm/openjdk-10.0.2/bin/jcmd 18831 PerfCounter.print
[snip]
java.rt.vmArgs="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.local.only=true -Dcom.sun.management.jmxremote.port=6969 -Dcom.sun.management.jmxremote.rmi.port=6969 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false"
[snip]

I can exclude these from the list of reasons

  • java version
  • using it with a .jar
  • running with an unprivileged user
  • is caused by service hardening

still open:

I currently tend to just leave it. It takes too much efforts to find the cause. We did not have any JVM heap data on pricenodes until now, we might visit that again once it issues show up.

@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 25, 2020
@freimair freimair force-pushed the networkmetric_installer branch from 23f73a9 to ebdff56 Compare February 27, 2020 09:25
@freimair freimair marked this pull request as ready for review February 27, 2020 10:25
@freimair freimair requested a review from cbeams as a code owner February 27, 2020 10:25
@ripcurlx ripcurlx requested a review from wiz February 27, 2020 10:55
@@ -67,6 +67,21 @@ curl http://localhost:8080/getVersion
curl http://localhost:8080/info
```

### Monitoring

If you run a main pricenode, you also are obliged to activate the monitoring feed by running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These "obligations" should be listed at https://bisq.wiki/Pricenode_Operator#Duties. I've just created that page as a stub. I've asked all @bisq-network/pricenode-operators to watch that page at bisq-network/roles#14 (comment), so changes you make there will have a reasonable chance of being seen by them (duty changes should be communicated and followed up on more explicitly in any case, but FYI the wiki page is there, and we should rally around it).

Copy link
Contributor Author

@freimair freimair Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. however, I do not have the authority to create directives. Creating directives can only be done by

  • the project leader,
  • the team leader of the team that is affected (the ops-team in this case), or
  • the team leader leader

at the time of writing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. By the powers vested in me as Admin team lead, I request that you transcribe what you've written here to the wiki, and as part of the overall delivery of task's parent project bisq-network/projects#13, announce that change to the @bisq-network/pricenode-operators team, and follow up that each operator actually complies. If you're not comfortable doing this, then please manage that @wiz does it in his role as ops team lead. The point is that changes like this are useless unless they're effectively communicated and followed up on. It doesn't mean you have to do the work yourself, but that you own that the work does get done. Updating a readme (or the wiki for that matter) on its own won't carry the day. Feel free to create an admin repo issue or issues about doing this documentation and communication work and request/suggest that @wiz be assigned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the above should not hold up the merging of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated the wiki to add running collectd as a "duty" with link to the README anchor that will exist after this PR is merged

pricenode/README.md Outdated Show resolved Hide resolved
@freimair freimair requested a review from cbeams February 27, 2020 16:51
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left just one minor suggestion as to wording and some notes on follow up process.

Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
running on gztmprecgqjq64zh pricenode, you should be getting data

@freimair freimair requested a review from cbeams February 28, 2020 11:52
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit ac3e588 into bisq-network:master Mar 9, 2020
@freimair freimair deleted the networkmetric_installer branch April 2, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants