-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust NetworkSize metric installer #4004
Adjust NetworkSize metric installer #4004
Conversation
23f73a9
to
ebdff56
Compare
@@ -67,6 +67,21 @@ curl http://localhost:8080/getVersion | |||
curl http://localhost:8080/info | |||
``` | |||
|
|||
### Monitoring | |||
|
|||
If you run a main pricenode, you also are obliged to activate the monitoring feed by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These "obligations" should be listed at https://bisq.wiki/Pricenode_Operator#Duties. I've just created that page as a stub. I've asked all @bisq-network/pricenode-operators to watch that page at bisq-network/roles#14 (comment), so changes you make there will have a reasonable chance of being seen by them (duty changes should be communicated and followed up on more explicitly in any case, but FYI the wiki page is there, and we should rally around it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. however, I do not have the authority to create directives. Creating directives can only be done by
- the project leader,
- the team leader of the team that is affected (the ops-team in this case), or
- the team leader leader
at the time of writing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. By the powers vested in me as Admin team lead, I request that you transcribe what you've written here to the wiki, and as part of the overall delivery of task's parent project bisq-network/projects#13, announce that change to the @bisq-network/pricenode-operators
team, and follow up that each operator actually complies. If you're not comfortable doing this, then please manage that @wiz does it in his role as ops team lead. The point is that changes like this are useless unless they're effectively communicated and followed up on. It doesn't mean you have to do the work yourself, but that you own that the work does get done. Updating a readme (or the wiki for that matter) on its own won't carry the day. Feel free to create an admin repo issue or issues about doing this documentation and communication work and request/suggest that @wiz be assigned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the above should not hold up the merging of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just updated the wiki to add running collectd as a "duty" with link to the README anchor that will exist after this PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left just one minor suggestion as to wording and some notes on follow up process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
running on gztmprecgqjq64zh pricenode, you should be getting data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
followup to #3997, part of bisq-network/projects#13
Tweak the networksize metric scraper script, the pricenode installer and amend the readme on how to use it.
notes to self:
cannot make the JVM fire up a jmx-service.standin jar works
[snip]
price node does not
I can exclude these from the list of reasons
still open:
I currently tend to just leave it. It takes too much efforts to find the cause. We did not have any JVM heap data on pricenodes until now, we might visit that again once it issues show up.