Revert setting of null to deposit tx id #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
reviewed
Feb 10, 2020
core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java
Outdated
Show resolved
Hide resolved
| public boolean equals(Object obj) { | ||
| if (this == obj) return true; | ||
| if (obj == null || getClass() != obj.getClass()) return false; | ||
| var wrapper = (WrapperTradeStatistics2) obj; |
There was a problem hiding this comment.
Don't you need a check that obj is actually a WrapperTradeStatistics2 here? Could cause an exception otherwise.
There was a problem hiding this comment.
Could add it to make it safer if it is reused somewhere.
Atm using it like that should not cause this case to ever happen.
.map(WrapperTradeStatistics2::new)
.distinct()
There was a problem hiding this comment.
But will add a check to be sure
There was a problem hiding this comment.
ah wait - I've added it already 😉
if (obj == null || getClass() != obj.getClass()) return false;
There was a problem hiding this comment.
Oh, right, that's right, missed it.
Co-Authored-By: sqrrm <[email protected]>
|
Perhaps we should not leave this one as |
sqrrm
approved these changes
Feb 10, 2020
ripcurlx
added
the
is:priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we saw some unexpected behavior during testing we decided to move this change to v1.2.7
Additionally we'll remove even more information from the trade statistics objects and will deploy it together with changes
in the offer objects.