Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The markets page is publishing duplicates of trades #338

Closed
huey735 opened this issue Feb 9, 2020 · 5 comments
Closed

The markets page is publishing duplicates of trades #338

huey735 opened this issue Feb 9, 2020 · 5 comments

Comments

@huey735
Copy link
Contributor

huey735 commented Feb 9, 2020

Description

The bisq.network/markets page is publishing the same trade twice seemingly for all markets. This issue seems to have started on February 7th 2020. From looking at the big markets, the first instance of the issue seems to be at 15h33m10s for the EUR market.

Screenshots

Screenshot from 2020-02-09 15-43-31
Screenshot from 2020-02-09 15-43-51
Screenshot from 2020-02-09 15-58-17

@wiz @ripcurlx I think I caught you discussing it, so I thought I'd mention you both here.

@huey735 huey735 changed the title 28ddb4 - The markets page is publishing duplicates of trades The markets page is publishing duplicates of trades Feb 9, 2020
@wiz
Copy link
Contributor

wiz commented Feb 9, 2020

Thanks for reporting, but yeah, we know - unfortunately v1.2.6 release branch has some major issues which we are working on, yesterday I had upgraded the node which serves data to the Markets API but reverting it to v1.2.5 now

@wiz
Copy link
Contributor

wiz commented Feb 9, 2020

BTW in the future you can report market issues to bisq-markets repo

@wiz
Copy link
Contributor

wiz commented Feb 10, 2020

@huey735 can you confirm this issue is resolved and if so close the issue? thanks

@huey735
Copy link
Contributor Author

huey735 commented Feb 10, 2020

It does look like it's fixed. In the future I'll make sure to post it on the correct repository.

@huey735 huey735 closed this as completed Feb 10, 2020
@ripcurlx
Copy link
Contributor

There are still around 400 trade statistic duplicates in the data store that were added by trading with our current master (which have the v1.2.6) changes in there. As soon as bisq-network/bisq#3958 is merged and deployed these duplications should be remove as well. Including the privacy test trades by @wiz 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants