Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tor, netlayer, jtorctl #3526

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

freimair
Copy link
Contributor

As always, these three come in one commit

  • tor has been updated to the recently released version 0.4.1.6
  • jtorctl has been updated to 1.4. It now features a callback that tells us whether the tor control connection is still alive
  • netlayer has been upgraded to 0.6.6. It just adapts the new jtorctl and uses the updated tor version

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 4, 2019

@freimair Did you experience any issues, while testing it on production?

@freimair
Copy link
Contributor Author

freimair commented Nov 4, 2019

no, no issues.

is just a minor Tor update with some bug fixes. Should be good.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Rebased locally to current master and started the app and it looks like everything is working as before

@ripcurlx ripcurlx merged commit ad93606 into bisq-network:master Nov 4, 2019
@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 6, 2019

@freimair I have to revert this PR as @devinbileck had issues using this Tor version on Windows.

Nov-05 15:28:59.456 [NetworkNode-9999] ERROR b.n.p2p.network.TorNetworkNode: Tor node creation failed: net.freehaven.tor.control.TorControlTimeoutError: We did not receive a response after one minute of waiting. 
Nov-05 15:28:59.459 [JavaFX Application Thread] ERROR bisq.core.app.P2PNetworkSetup: onSetupFailed

As it is too risky to have it for this release I'm reverting this PR until we know more details why this is happening on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants